Skip to content

[roottest][io] Bring back __CLING__ guard in Hard2Stream members - #20646

Closed
guitargeek wants to merge 1 commit into
root-project:masterfrom
guitargeek:fixup_cint_to_cling
Closed

guitargeek wants to merge 1 commit into
root-project:masterfrom
guitargeek:fixup_cint_to_cling

Conversation

@guitargeek

Copy link
Copy Markdown
Contributor

Follows up on 5727e1d, bringing back a __CINT__ preprocessor guard that should have stayed and rename it to __CLING__.

Address https://github.com/root-project/root/pull/20613/files#r2590556753

Follows up on 5727e1d, bringing back a `__CINT__` preprocessor guard
that should have stayed and rename it to `__CLING__`.
@guitargeek
guitargeek requested a review from pcanal December 4, 2025 22:08
@guitargeek
guitargeek requested a review from dpiparo as a code owner December 4, 2025 22:08

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pcanal
pcanal self-requested a review December 4, 2025 22:50
@pcanal

pcanal commented Dec 4, 2025

Copy link
Copy Markdown
Member

Apparently we are missing something :(

@guitargeek

Copy link
Copy Markdown
Contributor Author

Seems like it! You want to bring back the __CINT__ (and a comment) for now and try to understand the problem later?

But isn't __CINT__ a no-op now anyway? I don't understand what is going on, or why exactly the macro is required here 🙁

@pcanal
pcanal marked this pull request as draft December 4, 2025 23:44
@pcanal

pcanal commented Dec 4, 2025

Copy link
Copy Markdown
Member

Seems like it! You want to bring back the CINT (and a comment) for now and try to understand the problem later?

Nah ... but it looks like it was indeed no longer doing anything for that test and that the suggestion I made is the wrong thing (does not work) to accomplish the intent (ensuring that the I/O cannot/will not use the interpreter information for streaming - i.e. we don't want the test to succeed even though the Streamer function was not used).

So it looks like I need to find a better semantic replacement (and/or maybe I am lucky there is already part of the current test that does it some other way).

@pcanal pcanal self-assigned this Dec 4, 2025
@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 16h 16m 34s ⏱️
 3 783 tests  3 782 ✅ 0 💤  1 ❌
77 532 runs  77 511 ✅ 0 💤 21 ❌

For more details on these failures, see this check.

Results for commit bb0e482.

@guitargeek

Copy link
Copy Markdown
Contributor Author

Ok! I leave it to you then 🙂

@guitargeek guitargeek closed this Dec 8, 2025
@guitargeek
guitargeek deleted the fixup_cint_to_cling branch December 8, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants