Repository navigation
[CMake] Don't use find_package(ROOT REQUIRED) in test/ subdirectory - #20640
Merged
Merged
Conversation
guitargeek
added
in:Build System
clean build
guitargeek
force-pushed
the
roottest_cmake
branch
from
December 4, 2025 10:04
dfdc11a to
62d7351
Compare
vepadulano
reviewed
Dec 4, 2025
Test Results 22 files 22 suites 3d 19h 46m 25s ⏱️ Results for commit 994c94c. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Dec 4, 2025
pcanal
reviewed
Dec 4, 2025
pcanal
reviewed
Dec 4, 2025
Has been deprecated since ROOT 6.20 and can now be removed.
guitargeek
force-pushed
the
roottest_cmake
branch
from
December 4, 2025 23:52
62d7351 to
c2d7c6c
Compare
As Sergey said in the comment in `test/CMakeLists.txt`, this test project stopped working standalone. But, it still uses `find_package(ROOT)` to find ROOT, even though it's not installed yet as we are building ROOT itself at the same time. Apparently that works, and sets the flags like `ROOT_opengl_FOUND`, but we should not rely on this and use the build-time configuration flags instead.
guitargeek
force-pushed
the
roottest_cmake
branch
from
December 5, 2025 08:18
c2d7c6c to
994c94c
Compare
Contributor
Author
|
@pcanal, I addressed all your inline comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Sergey said in the comment in
test/CMakeLists.txt, this testproject stopped working standalone. But, it still uses
find_package(ROOT)to find ROOT, even though it's not installed yet aswe are building ROOT itself at the same time.
Apparently that works, and sets the flags like
ROOT_opengl_FOUND, butwe should not rely on this and use the build-time configuration flags
instead.