Skip to content

[core] publish alias since it appears in public function ret type or arg - #20576

Merged
dpiparo merged 4 commits into
root-project:masterfrom
ferdymercury:patch-15
Dec 15, 2025
Merged

dpiparo merged 4 commits into
root-project:masterfrom
ferdymercury:patch-15

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Nov 30, 2025 •

Copy link
Copy Markdown
Collaborator

Fixes #20572

@grasph would this change solve your issue?

@github-actions

github-actions Bot commented Nov 30, 2025 •

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 20h 40m 22s ⏱️
 3 788 tests  3 788 ✅ 0 💤 0 ❌
77 596 runs  77 596 ✅ 0 💤 0 ❌

Results for commit f98821f.

♻️ This comment has been updated with latest results.

@ferdymercury
ferdymercury marked this pull request as ready for review November 30, 2025 14:55
@grasph

grasph commented Nov 30, 2025

Copy link
Copy Markdown
Contributor

Yes, it does. Thanks. There few other similar cases:

@silverweed silverweed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ferdymercury ferdymercury changed the title [core] returned type public [core] publish alias since it appears in public function ret type or arg Dec 1, 2025
@vepadulano

Copy link
Copy Markdown
Member

@pcanal what do you think about this one?

@ferdymercury
ferdymercury marked this pull request as draft December 3, 2025 16:50

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pcanal pcanal closed this Dec 4, 2025
@pcanal pcanal reopened this Dec 4, 2025
@ferdymercury

ferdymercury commented Dec 8, 2025 •

Copy link
Copy Markdown
Collaborator Author

Thanks.

It seems TTabCom test is failing on some platforms. Not sure if it's a real issue, or if it's just a clean-build label missing?

EDIT: Danilo found out: it's because Windows has no pcms and the failing alma9-build is with modules=OFF

See also: #20716

@ferdymercury
ferdymercury marked this pull request as ready for review December 15, 2025 16:13
@dpiparo
dpiparo merged commit 3589c7a into root-project:master Dec 15, 2025
28 of 29 checks passed
@ferdymercury
ferdymercury deleted the patch-15 branch December 15, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A public field with a "private" type in the TFileMergeInfo class

6 participants