test: skip flaky live GStreamer pipeline on macOS#454
Merged
Conversation
signal__non-introspected.js failed intermittently on macOS CI: the subprocess printed "Success" for the signal-name assertion and then exited non-zero almost instantly (~0.1s, not the 1s pipeline timeout), i.e. the live videotestsrc→typefind pipeline crashes during teardown on macOS while passing on Linux and Windows. Hoist the actual unit under test (signal name validation throws) into its own `it` so it keeps running on every platform, then skip only the live pipeline portion on darwin. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
masteris red becausesignal__non-introspected.jsfails on macOS only (Linux and Windows pass). It's flaky — the previous master run passed.Failure signature from the macOS log: the subprocess prints
Successfor the signal-name assertion and then exits non-zero almost instantly (~0.1s — far below the test's own 1s pipeline timeout, and with noFailed/timeoutoutput). That points to a crash during teardown of the livevideotestsrc → typefindGStreamer pipeline on macOS, not the assertion itself.Note this is unrelated to the just-merged #451 (vfunc chain-up): that change only touches class-registration native code, which this test never exercises. This is pre-existing macOS flakiness that surfaced now.
Fix
Signal name is invalid— into its ownit, so it keeps running on every platform (it doesn't need a running pipeline).darwin, matching the existing convention used inregister-class__vfunc_chain_up.js(vfunc chain-up (super.<vfunc>()) crashes on macOS in g_vfunc_info_invoke #453 / 70e2b1c).Verification
Reworked test passes repeatedly on Linux (
exit=0). On macOS the assertion still runs (and would fail the build if it regressed) before the live portion is skipped viaskip()→ exit 222 → pending.🤖 Generated with Claude Code