feat(config): get default diagnostic icons from :sign config#461
Closed
Iron-E wants to merge 5 commits into
Closed
feat(config): get default diagnostic icons from :sign config#461Iron-E wants to merge 5 commits into
:sign config#461Iron-E wants to merge 5 commits into
Conversation
If you do:
```lua
require'barbar'.setup {
icons = {
diagnostics = {
[vim.diagnostic.ERROR] = {enabled = true},
[vim.diagnostic.HINT] = {enabled = true},
},
},
}
```
…it will not work. This is because a function in `Buffer` was using
`ipairs`, which stops upon reaching the first `nil` numerical index in a
`table`. However, upon fixing this, I discovered another bug: `icons`
was not being fully merged.
We had a snippet of code to "deep extend" `icons.diagnostics`, but since
we were only using `vim.tbl_deep_extend` on the other `icons` options,
they did not inherit the diagnostics. I extracted this snippet to a
function and called it on all `icons.modified`, `icons.current`, etc.
We reference distinct sides of the barbar often enough that it probably deserves its own alias.
We already had a `current_buffer_index` variable in `get_bufferline_containers`, so we can use that instead of storing all the activities of each buffer in their containers and looping over the buffers in each container looking for the current buffer, Apologies for the style changes; I was debugging something else, and had a really hard time reading this particular section. While reading through to understand the changes I discovered this performance improvement.
Collaborator
Author
|
Probably not a good idea. Not everyone configures these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff looks absurd because it's based on #451.
Uses
sign_getdefinedto generate the default icon, rather than hard-coding it.