fix(replace): objectGuards doesn't take effects #1764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@ikkz it looks like you need to rebase on upstream/master for CI to run. |
BREAKING CHANGES: Fixed the problem that the objectGuards option did not take effect, so the bundle results before and after may be inconsistent
Contributor
Author
|
@shellscape I have rebased. Could you please review it again? Thanks! |
shellscape
approved these changes
Sep 23, 2024
Contributor
|
I noticed that |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
{replace}This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: #1084 and #1178
Description
The plugin-replace's option
objectGuardsdoesn't take effects actually. It is caused mainly by the wrong implementation of functionexpandTypeofReplacements.On master, this function expands
process.env.NODE_ENVtotypeof process ...andtypeof env ..., which is unreasonable. The correct result should betypeof processandtypeof process.env. And the expanded keys won't match the default right delimiters (related comment)