Simplify convertChipType and fix truncation error.#67
Open
flatmax wants to merge 1 commit intorockchip-linux:masterfrom
Open
Simplify convertChipType and fix truncation error.#67flatmax wants to merge 1 commit intorockchip-linux:masterfrom
flatmax wants to merge 1 commit intorockchip-linux:masterfrom
Conversation
The error stopping compilations is format-truncation.
|
Looks good to me! |
|
Can't it happen that this reads beyond the buffer? There's #57 to make it safer. |
Contributor
Author
|
Yes. That means that the caller has to ensure safety, while the function itself doesn't provide it. That's a lack of resiliece. :-) |
martinSusz
added a commit
to martinSusz/rkdeveloptool
that referenced
this pull request
Dec 2, 2022
Alternative solution to rockchip-linux#67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error stopping compilations is format-truncation.