First rought version of ply-exporter#28
First rought version of ply-exporter#28goldhoorn wants to merge 4 commits intorock-simulation:masterfrom
Conversation
|
Could you please remove the warning and if hack_aperture is not a good variable name in the mainstream you can change it to aperture_file? |
|
Is this really needed or could the whole "hack "block removed? On 11.02.2015 09:22, malter wrote:
Dipl.-Inf. Matthias Goldhoorn Universität Bremen Zentrale: +49 421 178 45-6611 Besuchsadresse der Nebengeschäftstelle: Tel.: +49 421 178 45-4193 Weitere Informationen: http://www.informatik.uni-bremen.de/robotik |
|
updated |
|
@malter pong |
|
@malter : do you accept this or do i need to change something?? |
|
It would be better if the depth texture is only created when it is used the first time? |
|
don't know then there might be a delay (e.G. the first frame might not have been captured?!) |
|
Maybe, if you want to use the ply export you have to initialize the use of the depth buffer by calling the function once at the beginning or we add a initDepthBuffer to the GraphicsManagerInterface. But still it would be better to render the depth buffer only to texture if required. |
|
updated |
|
did you pushed your changes? |
|
Yep, but to the wrong branch ;), now this one |
|
pong |
|
@malter dupdidu |
|
@malter : pong? |
No description provided.