chore: optimize reading logical time from samples in the trivial cases#60
Open
doudou wants to merge 2 commits intoresize_containersfrom
Open
chore: optimize reading logical time from samples in the trivial cases#60doudou wants to merge 2 commits intoresize_containersfrom
doudou wants to merge 2 commits intoresize_containersfrom
Conversation
doudou
force-pushed
the
opt_logical_time_reading
branch
from
6cf3437 to
da6da7e
Compare
wvmcastro
approved these changes
Feb 27, 2026
|
|
||
| def extract_logical_time(raw_payload) | ||
| return unless @logical_time_field | ||
| def self.compound_field_directly_addressable?(compound_type, field_name) |
Contributor
There was a problem hiding this comment.
Doc: a field is directly addressable if it is declared before a container field type
Comment on lines
+220
to
+222
| Output.compound_field_directly_addressable?( | ||
| field_type, "microseconds" | ||
| ) |
Contributor
There was a problem hiding this comment.
Your intention with the second check is to verify that field_type is "base/Time" ?
This speeds up the normalization process significantly (x5) on types that need this "fix".
Strictly speaking, we don't have to, but let's strive to have a good balance between genericity and complexity ;-)
doudou
force-pushed
the
opt_logical_time_reading
branch
from
da6da7e to
2ec3df1
Compare
doudou
force-pushed
the
resize_containers
branch
from
1aa2ecd to
756b1f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speeds up the normalization process significantly (x5) on types that need this "fix".