fix: resize containers when extracting the logical time#59
Open
fix: resize containers when extracting the logical time#59
Conversation
wvmcastro
approved these changes
Mar 3, 2026
If the marshalled type has a container size that is smaller than the reading system's native type, the resulting memory zone will be too small and things will crash Pocolog::DataStream does it, but since the normalization codepath uses BlockStream for speed reasons, we have to do it here as well.
The refactoring of the previous commit has a bug, which shows that the test was doing nothing. Namely, we were passing the rock_timestamp_field metadata, but syskit-log would do nothing anyways because no fields were marked as logical_time.
doudou
force-pushed
the
resize_containers
branch
from
1aa2ecd to
756b1f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
If the marshalled type has a container size that is smaller than the reading
system's native type, the resulting memory zone will be too small and things
will crash
Pocolog::DataStream does it, but since the normalization codepath uses
BlockStream for speed reasons, we have to do it here as well.