-
Notifications
You must be signed in to change notification settings - Fork 19
Added vcs-type subpackage. #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skasperski
wants to merge
9
commits into
rock-core:master
Choose a base branch
from
skasperski:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ecedc2c
Added vcs-type subpackage.
skasperski 9978432
Resolve rubocop complaints.
skasperski 41ff736
Use multi-line again.
skasperski ab39b92
Fix call parameter.
skasperski 04c69ca
Do not call parent importer directly.
skasperski 3ca9360
Added dummy snapshot.
skasperski a45df0a
Put comments on extra line.
skasperski f033c3e
Fix rubocop again.
skasperski 0e8caa8
Fix rubocop again #3.
skasperski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| module Autobuild | ||
| class Subpackage < Importer | ||
| def initialize(source, options = {}) | ||
| @source = source | ||
|
|
||
| parent_name = options[:parent] | ||
| unless parent_name | ||
| raise PackageException, | ||
| "Subpackage must provide a parent package." | ||
| end | ||
|
|
||
| @parent = Autoproj.workspace.manifest.package_definition_by_name(parent_name) | ||
| unless @parent | ||
| raise PackageException, | ||
| "Parent package #{parent_name} does not exist." | ||
| end | ||
|
|
||
| super(options.merge(repository_id: source)) | ||
| end | ||
|
|
||
| # Does nothing, parent will do update | ||
| def update(_package, _options = Hash.new) | ||
| false | ||
| end | ||
|
|
||
| # Does nothing, parent will be checked out | ||
| def checkout(package, _options = Hash.new) | ||
| package.depends_on(@parent.autobuild) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this is going to behave as expected, especially with |
||
| end | ||
|
|
||
| # Does nothing, parent will do snapshot | ||
| def snapshot(*) | ||
| true | ||
| end | ||
| end | ||
|
|
||
| def self.subpackage(source, options = {}) | ||
| Subpackage.new(source, options) | ||
| end | ||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autobuild cannot depend on autoproj