Minor patch #7
Closed
Minor patch #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dwlee Exceptions shouldn't be handled by just returning. You deny the user of the api a chance to see and handle errors himself which makes for very difficult to solve bugs. Can it be handled above this class? Should it convert the exception to a |
Collaborator
Author
|
I updated that |
Collaborator
Author
|
I moved this PR to #11 and closed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I prepared 3rd milestone, I fixed some parts.
In case of using low spec device (ex. nexus 10/ Lollipop), Concert checker occasionally returned
MasterInfomessage does not receive error. Because low spec device is not enough 4s for receiving message.The android app using MasterInfo class for checking concert is died if it run in only launched roscore.