Skip to content

chore: release v0.17.0 - #411

Merged
robo9k merged 1 commit into
mainfrom
release-plz-2025-10-01T14-41-50Z
Oct 30, 2026
Merged

robo9k merged 1 commit into
mainfrom
release-plz-2025-10-01T14-41-50Z

Conversation

@arbeitsmaschine

@arbeitsmaschine arbeitsmaschine Bot commented Oct 1, 2025 •

Copy link
Copy Markdown
Contributor

🤖 New release

  • magic: 0.16.7 -> 0.16.8 (✓ API compatible changes)
Changelog

0.16.8 - 2026-10-30

Added

  • make DatabasePaths Debug
  • make DatabasePaths Cloneable
  • Add missing cookie::Flags for supported libmagic versions

Other

  • Link to alternative pure Rust crate
  • (deps) Update Rust crate bitflags to v2.11.0
  • name separator b':'
  • Debug and Clone for DatabasePaths
  • (deps) Update Rust crate magic-sys to v0.4.2
  • Document libmagic version crate features
  • (deps) Upgrade magic-sys up to 0.4
  • (edition) Upgrade edition up to 2021


This PR was generated with release-plz.

@codecov

codecov Bot commented Oct 1, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.75%. Comparing base (1f83efa) to head (6a66120).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   46.75%   46.75%           
=======================================
  Files           2        2           
  Lines         509      509           
  Branches      509      509           
=======================================
  Hits          238      238           
  Misses        270      270           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arbeitsmaschine
arbeitsmaschine Bot force-pushed the release-plz-2025-10-01T14-41-50Z branch 3 times, most recently from 2b056ba to 3d9c8d9 Compare October 2, 2025 14:55
@robo9k robo9k mentioned this pull request Oct 2, 2025
@arbeitsmaschine
arbeitsmaschine Bot force-pushed the release-plz-2025-10-01T14-41-50Z branch 5 times, most recently from b5abca0 to a6a4fce Compare October 2, 2025 17:03
@arbeitsmaschine
arbeitsmaschine Bot force-pushed the release-plz-2025-10-01T14-41-50Z branch 5 times, most recently from 5fc8dd4 to 7ac2c67 Compare October 17, 2025 11:34
@robo9k

robo9k commented Mar 21, 2026

Copy link
Copy Markdown
Owner

#435 should also make it into this next release, but I've broken release-plz CI currently

@arbeitsmaschine
arbeitsmaschine Bot force-pushed the release-plz-2025-10-01T14-41-50Z branch 13 times, most recently from 472898f to 17f2210 Compare March 25, 2026 00:02
@arbeitsmaschine
arbeitsmaschine Bot force-pushed the release-plz-2025-10-01T14-41-50Z branch 7 times, most recently from 9f8d191 to 62b77d6 Compare March 28, 2026 22:18
@arbeitsmaschine
arbeitsmaschine Bot force-pushed the release-plz-2025-10-01T14-41-50Z branch 3 times, most recently from cb820de to bcd9a99 Compare October 30, 2026 14:16
@robo9k
robo9k force-pushed the release-plz-2025-10-01T14-41-50Z branch from bcd9a99 to 6a66120 Compare October 30, 2026 15:30
@robo9k robo9k changed the title chore: release v0.16.8 chore: release v0.17.0 Oct 30, 2026
@robo9k

robo9k commented Oct 30, 2026

Copy link
Copy Markdown
Owner

I've manually edited the changelog and other files to make this a breaking major release

@robo9k
robo9k marked this pull request as ready for review October 30, 2026 15:44
@robo9k

robo9k commented Oct 30, 2026

Copy link
Copy Markdown
Owner

#437 only updates the lock file for magic-sys v0.4.3, so not required for release

@robo9k
robo9k merged commit e2789b3 into main Oct 30, 2026
19 checks passed
@robo9k
robo9k deleted the release-plz-2025-10-01T14-41-50Z branch October 30, 2026 15:47
@robo9k

robo9k commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Urgh https://github.com/robo9k/rust-magic/actions/runs/41083964313/job/124160101625

  2026-10-30T15:48:11.027384Z  INFO release_plz::args::config_path: crates/release_plz/src/args/config_path.rs:67: using release-plz config file release-plz.toml
  2026-10-30T15:48:11.814886Z ERROR release_plz: crates/release_plz/src/main.rs:22: can't determine if package magic is published
  
  Caused by:
      0: timeout while checking if `magic` is published
      1: cargo info failed for magic@0.17.0: \x1b[0m\x1b[0m\x1b[1m\x1b[31merror\x1b[0m\x1b[1m:\x1b[0m no such subcommand: `info`
         
         	Did you mean `init`?
  Error: can't determine if package magic is published
  
  Caused by:
      0: timeout while checking if `magic` is published
      1: cargo info failed for magic@0.17.0: error: no such subcommand: `info`
         
         	Did you mean `init`?

The CI workflow runs with pinned stable Rust v1.88.0 which should have the cargo info that release-plz is expecting (but not v1.64).
Looks like this is due to https://redirect.github.com/release-plz/release-plz/pull/2645
The current docs for its action seem to just install latest stable toolchain https://release-plz.dev/docs/github/quickstart
Seems like the rustup cargo proxy is somehow not invoked with the intended symlinked version and I didn't find a release-plz issue for this yet

Let's try just bumping release-plz versions to what renovate wanted to do anyway in #460

@robo9k

robo9k commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Nope, still the same release-plz error in newer run https://github.com/robo9k/rust-magic/actions/runs/41090058109/job/124181291241

Let's see what happens when updating to latest release-plz ignoring dependency cooldowns in #461

@robo9k

robo9k commented Oct 30, 2026

Copy link
Copy Markdown
Owner

@robo9k

robo9k commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Finally a new error in https://github.com/robo9k/rust-magic/actions/runs/41094226187/job/124195664251 while trying to actually package the release prior to publishing

        cargo:warning=pkg-config failed: 
        pkg-config exited with status code 1
        > PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags libmagic 'libmagic >= 5.39'
      
        The system library `libmagic` required by crate `magic-sys` was not found.
        The file `libmagic.pc` needs to be installed and the PKG_CONFIG_PATH environment variable must contain its parent directory.
        The PKG_CONFIG_PATH environment variable is not set.
      
        HINT: if you have installed the library, try setting PKG_CONFIG_PATH to the directory containing `libmagic.pc`.

D'uh, libmagic has indeed not been installed in this CI workflow. How did that work previously, different runner packages?

@robo9k

robo9k commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant