Skip to content

fix: correct OutfitPages extends type (remove extra ReadonlyArray wrapper) #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhsj0089944 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correct OutfitPages extends type (remove extra ReadonlyArray wrapper) #1411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions include/customDefinitions.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,13 +152,11 @@ interface CaptureService extends Instance {
interface CatalogPages extends Pages<SearchCatalogResult> {}

interface OutfitPages
extends Pages<
ReadonlyArray<{
Id: number;
Name: string;
IsEditable: boolean;
}>
> {}
extends Pages<{

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate the published OutfitPages declarations

This override is only generator input: include/roblox.d.ts:5 and plugin.d.ts:2 load the committed generated files, while package.json:48 excludes include/customDefinitions.d.ts from the package. In this commit the generated outputs still declare OutfitPages extends Pages<ReadonlyArray<...>> in include/generated/None.d.ts:34150 and include/generated/PluginSecurity.d.ts:10057, so users of the published typings will still see the old nested-array type unless those generated files are regenerated and committed with this change.

Useful? React with 👍 / 👎.

Id: number;
Name: string;
IsEditable: boolean;
}> {}

interface BadgeService extends Instance {
/** @server */
Expand Down
Loading