Allow generic drawing effects #63

Activity

1. cammace commented on Apr 25, 2018

   

   cammace

   on Apr 25, 2018

   More actions

   subclass SparkView and do manual drawing

   So if I understand correctly, similiar to how the Paint objects have getter, and more importantly, setters, you'd like the same accessibility for the Paths? I would think we'd want to keep these not mutable since everytime populatePath is called, the path is reset and drawn again using the data from the adapter.

   If you mean setting the Paint objects like mentioned in #59, setSparkFillPaint is already exposed to the dev?
2. danh32 commented on Apr 25, 2018

   

   danh32

   on Apr 25, 2018

   ContributorAuthor

   More actions

   My super-rough idea so far is to have a class something like:

   interface SparkDraw {
     void draw(Canvas c, DrawArgs args);
   }
   
   class DrawArgs {
     public Path sparkPath;
     public Path sparkPaint;
     public float[] scaledPointsY;
     public float[] scaledPointsX;
     public float scrubY;
     public float scrubX;
     ...
   }
   

   Then users can override the draw there and mutate the paths/paints if they want crazier effects.

   This isn't super well thought out yet, though, definitely open to ideas here!
3. cammace commented on Apr 25, 2018

   

   cammace

   on Apr 25, 2018

   More actions

   DrawArgs sounds like it would clean up the SparkView significantly with all the getters and setters, we could even possibly throw in a createFromAttributes method which further shrinks the view class. I did something similar recently here.