Change RocksDB to check the assigned topic name #655
Open
g-clef wants to merge 1 commit intorobinhood:masterfrom
g-clef:fix-custom-changelog-keys
Open
Change RocksDB to check the assigned topic name #655g-clef wants to merge 1 commit intorobinhood:masterfrom g-clef:fix-custom-changelog-keys
g-clef wants to merge 1 commit intorobinhood:masterfrom
g-clef:fix-custom-changelog-keys
Conversation
…generated one in _dbs_for_actives
ask
reviewed
Sep 22, 2020
| def _dbs_for_actives(self) -> Iterator[DB]: | ||
| actives = self.app.assignor.assigned_actives() | ||
| topic = self.table._changelog_topic_name() | ||
| topic = self.table.changelog_topic_name |
Contributor
Author
There was a problem hiding this comment.
the underscore version is. The non-underscore version is an @property
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the RocksDB store to check the assigned topic name for a changelog, rather than the auto-generated one. If the changelog uses a manually-created topic, using the auto-generated name causes
keys(),values(),items()on theTableobject that this store backs to return no data, since the changelog names never match.Resolves #654