Skip to content

fix(plugin-engine): refresh shell env values#486

Open
robinebers wants to merge 1 commit into
mainfrom
cursor/a98359d3
Open

fix(plugin-engine): refresh shell env values#486
robinebers wants to merge 1 commit into
mainfrom
cursor/a98359d3

Conversation

@robinebers
Copy link
Copy Markdown
Owner

@robinebers robinebers commented May 22, 2026

Summary

Test plan

  • cargo test resolve_env_value_rechecks_shell_when_process_env_missing
  • cargo test env_api

Made with Cursor


Note

Cursor Bugbot is generating a summary for commit b53dc4f. Configure here.


Summary by cubic

Re-read shell-derived env vars on each lookup (no caching) while keeping process env precedence. This lets Spotlight-launched OpenUsage pick up updated shell config without restart and fixes #305.

  • Bug Fixes
    • Removed terminal env cache; if a var isn’t in the process env, we now re-read from interactive shells every time.
    • Introduced resolve_env_value_with_readers for clearer logic and testability, plus a test to verify repeated shell reads.

Written for commit b53dc4f. Summary will update on new commits. Review in cubic

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the rust Pull requests that update rust code label May 22, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimax "Request failed" unless started from the terminal

1 participant