Add 'type handlers' that allow users to easily support types we don't handle #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluba
approved these changes
Jun 24, 2025
Owner
rluba
left a comment
rluba
left a comment
There was a problem hiding this comment.
Thanks, this looks good! Do you have a sample implementation for any type that we could add to examples/example.jai to (a) document how it works and (b) use as a regression test?
| return write_integer(col, name, info, slot, col_type, val); | ||
| } | ||
|
|
||
| case .UUID; #through; // UUIDs are simplye [16]u8, returned from postgres as a byte array |
Contributor
Author
There was a problem hiding this comment.
I thought it was too obvious, but in retrospect perhaps not. I think you should keep the comment :)
Contributor
Author
There was a problem hiding this comment.
I readded the comment 👍🏻
Contributor
Author
|
Regarding a reference implementation, currently the only one I have is jai-pgvector, which is 1 file of ~130 lines. Perhaps we can add that as a module and use it in the example, and reference it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Raphael,
I have made a small addition that allows users to inject 'handlers' at runtime to add support for types that aren't handled by default. As an example of how this is used, I have made jai-pgvector, which adds support for the
vectortype from the popularpgvectorextension, which we need in our company.This should also make it very easy for others to add support for other types and other extensions, like PostGIS, for example. If you like, we can also use this ability to add some of the more popular types and extensions in
Jaipgitself, as an on-demand feature (e.g. people who want pgvector callinit_pgvectoror similar).Wish you a nice day 😊