Update RRule.php - #170
Closed
Krakozaber wants to merge 1 commit into
Closed
Conversation
FIX: with message 'The return value of method DateTimeImmutable::setTimezone() should either be used or intentionally ignored by casting it as (void), as DateTimeImmutable::setTimezone() does not modify the object itself' in /mnt/data/www/pirs/vendor/rlanvin/php-rrule/src/RRule.php:749
Author
|
@rlanvin Is this package alive? |
Owner
|
Hello, Yes - I just don't have a lot of time to dedicate to maintenance at the moment. Can you tell me more about the context of this error? Maybe add a test to reproduce it? Your description is a bit vague at the moment. |
Author
Just $date->setTimeZone($this->dtstart->getTimezone()); should be written to a variable |
Owner
|
Thank you for reporting this. I'm closing your PR in favour of PR #171 which covers more cases and includes tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: with message 'The return value of method DateTimeImmutable::setTimezone() should either be used or intentionally ignored by casting it as (void), as DateTimeImmutable::setTimezone() does not modify the object itself'
in /mnt/data/www/pirs/vendor/rlanvin/php-rrule/src/RRule.php:749