Skip to content

Switch to use Feature::Compat::Try instead of Try::Tiny - #717

Open
Leont wants to merge 1 commit into
rjbs:mainfrom
Leont:fct
Open

Switch to use Feature::Compat::Try instead of Try::Tiny#717
Leont wants to merge 1 commit into
rjbs:mainfrom
Leont:fct

Conversation

@Leont

@Leont Leont commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

This makes it «use feature 'try'» on perl 5.36 and up, and use Syntax::Feature::Try on older versions.

This makes it «use feature 'try'» on perl 5.36 and up, and use
Syntax::Feature::Try on older versions.
@rjbs

rjbs commented Dec 9, 2022

Copy link
Copy Markdown
Owner

I am pretty hesitant here. I think Dist::Zilla has never used experimental features, and I'm not sure I want to start now.

@Leont

Leont commented Dec 9, 2022

Copy link
Copy Markdown
Contributor Author

Fair enough, it can wait.

Would that make Syntax::Keyword::Try a better option?

@rjbs

rjbs commented Dec 9, 2022

Copy link
Copy Markdown
Owner

I don't know, because I'm not sure what the benefit of using this over Try::Tiny is, here. What are we getting?

@Grinnz

Grinnz commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Efficiency, ability to use return normally, avoidance of superglobals, similarity to the upcoming 'try' feature!

@Grinnz

Grinnz commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Just make sure to use Syntax::Keyword::Try not the unrelated Syntax::Feature::Try 😄

@karenetheridge

Copy link
Copy Markdown
Contributor

not the unrelated Syntax::Feature::Try

gah! I didn't realize that existed.. we should watch out for this.

@Leont

Leont commented Dec 10, 2022

Copy link
Copy Markdown
Contributor Author

Just make sure to use Syntax::Keyword::Try not the unrelated Syntax::Feature::Try smile

Yeah I keep confusing them, have to check the author to know which one I want

@rjbs
rjbs force-pushed the main branch 10 times, most recently from 9361f28 to f825e3b Compare June 3, 2024 00:37
@rjbs
rjbs force-pushed the main branch 2 times, most recently from 40e530a to 370397c Compare November 7, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants