-
Notifications
You must be signed in to change notification settings - Fork 41
chore(core): add x-rivet-endpoint header for serverless runners & cleanup severless runner setup #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
NathanFlurry
wants to merge
1
commit into
main
from
10-06-chore_core_add_x-rivet-endpoint_header_for_serverless_runners_cleanup_severless_runner_setup
Closed
chore(core): add x-rivet-endpoint header for serverless runners & cleanup severless runner setup #1359
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { z } from "zod"; | ||
|
||
export const ServerlessStartHeadersSchema = z.object({ | ||
endpoint: z.string({ required_error: "x-rivet-endpoint header is required" }), | ||
token: z | ||
.string({ invalid_type_error: "x-rivet-token header must be a string" }) | ||
.optional(), | ||
totalSlots: z.coerce | ||
.number({ | ||
invalid_type_error: "x-rivet-total-slots header must be a number", | ||
}) | ||
.int("x-rivet-total-slots header must be an integer") | ||
.gte(1, "x-rivet-total-slots header must be positive"), | ||
runnerName: z.string({ | ||
required_error: "x-rivet-runner-name header is required", | ||
}), | ||
namespace: z.string({ | ||
required_error: "x-rivet-namespace-id header is required", | ||
}), | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a redundant self-reference in this line. The expression
runConfig.token ?? runConfig.token
will always evaluate torunConfig.token
since the nullish coalescing operator (??
) only uses the right-hand value when the left-hand value isnull
orundefined
.Since the
config
parameter was removed from this function, this should be simplified to:Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.