preserve large numeric job args - #594
Merged
Merged
Conversation
bgentry
changed the title
Collaborator
|
@bgentry Hey do you know if this one's still necessary/desirable? |
bgentry
force-pushed
the
bg/fix-job-args-precision
branch
2 times, most recently
from
August 1, 2026 00:21
a2ae51b to
d8226e6
Compare
Job args can contain database identifiers that exceed JavaScript's safe integer range. Returning args as nested JSON lets `response.json()` round numeric literals before River UI renders or copies them. Return args as JSON text from the standard and Pro serializers and map the field to `argsRaw` in the frontend. Parse the text into a lossless view model that preserves numeric tokens, sorts object keys, keeps collapsible detail views, and bounds work for pathological payloads. Skip formatting list args when they are hidden. Cover the wire contract, browser fetch mapping, JSON grammar and safety limits, sorted display and copy behavior, and list/detail rendering. Closes #593
bgentry
force-pushed
the
bg/fix-job-args-precision
branch
from
August 1, 2026 00:36
d8226e6 to
7058dc5
Compare
bgentry
marked this pull request as ready for review
August 1, 2026 02:16
Contributor
Author
|
Yes still relevant, should be about ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job args can contain database identifiers larger than JavaScript's safe integer range. Returning args as nested JSON lets browser parsing round those literals before the list and detail pages render or copy them.
This changes job-shaped API responses to return args as JSON text and maps the value to
argsRawin the frontend. A bounded lossless parser preserves numeric tokens while recursively sorting object keys for display and copied output.Job and workflow details retain the existing collapsible structured viewer, list formatting is skipped when args are hidden, and malformed or pathologically nested payloads fall back to literal text.
Closes #593.