fix: use exact-key for MemoryLocationHash instead of u64 to defend ha…#517
Open
phuocthanhdo wants to merge 1 commit into
Open
fix: use exact-key for MemoryLocationHash instead of u64 to defend ha…#517phuocthanhdo wants to merge 1 commit into
phuocthanhdo wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
benchmark |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the u64 type alias for MemoryLocationHash with a dedicated struct containing both the precomputed u64 hash and the underlying MemoryLocation. This prevents hash collisions (aliasing) by implementing custom PartialEq and Hash traits that compare the full location on hash hits while preserving the fast u64 path for distinct locations. Corresponding updates are made to MemoryLocation (deriving Copy), hash_deterministic, get_rewards signatures, and the initial from_hash value in vm.rs. There are no review comments, so no additional feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
✅ Gigagas benchmark for commit 4519033 Detail |
|
✅ Mainnet benchmark for commit 4519033 This pr: Detail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sh collision