added missing assert to mm execution test in auto tuning#229
Open
johanneslenfers wants to merge 1 commit intomainfrom
Open
added missing assert to mm execution test in auto tuning#229johanneslenfers wants to merge 1 commit intomainfrom
johanneslenfers wants to merge 1 commit intomainfrom
Conversation
Member
|
I think ideally tests should be able to discriminate between different execution errors. For example in this case I think the test should only be allowed to pass if the The next step after that would be to query things like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mm example execution as part of the auto tuning tests is a heavy workload if running on a non-gpu device. Therefore, the execution is allowed to fail with an
EXECUTION_ERROR. This PR adds the missingassert.