This repository was archived by the owner on May 29, 2024. It is now read-only.
Open
Conversation
added 2 commits
August 17, 2017 13:51
will be logged as soon as printing thistemplate is attempted.
ghost
mentioned this pull request
Closed
python-magic(rpm) and python-magic(pip) conflict on all installs If pip is installed, the pip version will always be retreived and used. In systems without pip, python-magic is not found if in the setup.py requirements, even if the code itself does not run into any problems. Providing a custom python-magic-pip fails in different constellations.
Author
|
The magic-dependency-on-rpms solution now documented is not the most elegant and satisfying one, but I'm out of ideas how to trick python/easyinstall/whomever into just running the code instead of checking a list that's supposed to be there for setup (i.e. not executing). may be of interest to @toirl , @ThomasJunk , @gsiv . |
removed internal testing version number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll require a package 'python-magic-pypi' (which is just the pypi version of 'python-magic' repackaged). By renaming we'll avoid yet another confusing clash in the future, and the name should alert people on what the package contains.Minor stuff that relates to the magic.
Please note that some code now becomes unused (as there should be only one kind of magic), which I did not touch yet