monitoring: register cost services and expose hourly cost metric#696
Merged
Conversation
Contributor
|
Kindly resolve conflict and fix workflow. |
Author
|
Maintainer please approve submitted pr |
Contributor
|
Please the conflict is yet to be resolved. |
1746a1f to
8c15b99
Compare
Contributor
|
Thank you for contributing to the project. |
Author
|
Hello @RUKAYAT-CODER, I have successfully rebased the branch onto the latest upstream/main entirely and I have resolved the conflicts in monitoring.module.ts, and squashed the redundant build cache commits. The PR history is now clean, linear, and ready for your review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Closes #616
Summary
Register cost monitoring services to enable collection, tracking, and exposure of the
infra_hourly_cost_usdmetric for operational dashboards, monitoring, and alerting workflows.Changes
CostTrackingServiceto support infrastructure cost metric tracking.CostSchedulerServiceto schedule periodic cost metric collection.AwsCostCollectorServiceto provide AWS cost data collection capabilities.monitoring.module.tsproviders and exports for application-wide availability.Files Changed
monitoring.module.tsTesting
Ran monitoring unit tests:
npm test -- --testPathPattern=monitoring -iAll monitoring-related tests passed successfully.
Notes / Follow-ups
The scheduler currently records a placeholder hourly cost value (
0) until cost data integration is completed.Future enhancements include:
POST /metrics/costfor local cost metric ingestion and validation.GET /monitoring/cost/summaryfor cost reporting and monitoring.#Closes