Open
Conversation
zcqno1
reviewed
Dec 28, 2018
| //cols | ||
| res.cols = fields.map(function(key,i) { | ||
| return { | ||
| caption: headers[i], |
There was a problem hiding this comment.
When config is undefined, fields instanceof Array === true.
So it would not go in to the if case telling in line 56 and headers remain [].
When json is not empty([] || {}), fields is also not empty, then headers would not match fields.
headers[i] in line 68 would be undefined, resulting to the following failure of test.
## fix it
Replace headers[i] to headers[i] !== undefined ? headers[i] : key in line 68.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added possibility to set header for a column