Conversation
Minnozz
left a comment
Minnozz
left a comment
There was a problem hiding this comment.
Awesome, I was just starting to look into using Reductive with ReScript.
I noticed some converted code that might not be idiomatic / officially supported in ReScript. Also, the README still contains references to Reason.
| | B => state ++ "b" | ||
| } | ||
|
|
||
| type ReduxThunk.thunk<_> += |
There was a problem hiding this comment.
Not sure if this is idiomatic / officially supported in ReScript: rescript-lang/rescript-lang.org#135
There was a problem hiding this comment.
I think this is supported (talking about current state) but not documented just like row polymorphism and other advanced stuff.
but definitely examples need some improvement.
| } | ||
|
|
||
| let thunkedLoggedTimeTravelLogger = (store, next) => | ||
| \"@@"(Middleware.thunk(store), \"@@"(Middleware.logger(store), \"@@"(timeTravel(store), next))) |
There was a problem hiding this comment.
I don't think the @@ operator officially exists in ReScript. It is not listed here.
There was a problem hiding this comment.
yeah the application operator is not supported.
|
@amiralies Do you intend to continue working on this PR? Can you use help? |
|
@Minnozz I can address the issues but I'm curious if ricky @rickyvetter willing to continue maintaining this since I didn't get response from him |
|
@amiralies, I like your pr, today I build you branch on my machine and found it build successfully! but I can't build successfully in the master branch. But when I run the example of todomvcEntry.res, it doesn't work, the I just got blank browser page. |
3 participants
closes #74
What does this PR do: