Fix Access Violation in Multiplayer Lobby when player is removed from the room#296
Open
LIFEfreedom wants to merge 1 commit into
Conversation
67bc53d to
d8c87c4
Compare
Collaborator
|
If this analysis is true, we should not be processing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bug: A client would experience an
EAccessViolationwhen receiving a mkPlayersList network message right as they were being removed from the multiplayer room (e.g., kicked by the host or dropped). (my guess)Root Cause: When a joiner receives the
mkPlayersListpacket,TKMNetworking.HandleMessagePlayersListupdates the local room state and recalculates the client's own index (fMySlotIndex):If the player's nickname was no longer present in the updated room list,
fMySlotIndexwas correctly set to-1. However, the code then unconditionally triggeredOnPlayersSetup(TKMGamePlayInterface.AlliesOnPlayerSetup).Inside
AlliesOnPlayerSetup, the UI attempts to read properties likegNetworking.MyRoomSlot.VotedYes. BecausefMySlotIndexwas-1,GetMyRoomSlotreturned nil, leading to an immediateAccess Violationupon dereferencing the memory offset for VotedYes.