Skip to content

fix compilation with FPC + Lazarus of campaigns sorting algorithm#198

Open
dpronin wants to merge 3 commits into
reyandme:masterfrom
dpronin:KM_Campaigns/sorting-algorithm-update
Open

fix compilation with FPC + Lazarus of campaigns sorting algorithm#198
dpronin wants to merge 3 commits into
reyandme:masterfrom
dpronin:KM_Campaigns/sorting-algorithm-update

Conversation

@dpronin
Copy link
Copy Markdown

@dpronin dpronin commented Jan 8, 2024

FPC and Lazarus on Linux do not have List.List[] property, but List fortunately has Sort() method at Linux platform with a comparator to give from a call site

Please, consider these changes to merge them in. The previous business logic of Windows's implementation has been preserved

@dpronin dpronin force-pushed the KM_Campaigns/sorting-algorithm-update branch 2 times, most recently from ea70219 to eb4a61d Compare January 8, 2024 09:23
@dpronin
Copy link
Copy Markdown
Author

dpronin commented Jan 8, 2024

I think these changes are easy to verify. We need to get list of current campaigns in the game and see that they are sorted according to the rules. Then we could create a dummy campaign, if it is possible, with the smallest efforts undertaken and name them with TSK, TPR and different other names and see that they are again sorted. Or, if it is possible and there is a list of such campaigns in resources, we might create dummy files and see that their names are sorted according to the rules

@reyandme
Copy link
Copy Markdown
Owner

reyandme commented Jan 8, 2024

Yes, this or similar test should be done.
Could you do such a test please ?
I would be able to do it, but some time later.

@dpronin
Copy link
Copy Markdown
Author

dpronin commented Jan 8, 2024

Actually, I don't have Windows, neither installed nor an installer to install

@sado1
Copy link
Copy Markdown

sado1 commented Jan 9, 2024

as in the other MR, I could test those changes eventually
it seems like a low risk change

@dpronin
Copy link
Copy Markdown
Author

dpronin commented Jan 9, 2024

as in the other MR, I could test those changes eventually it seems like a low risk change

I would appreciate if you did

@dpronin dpronin force-pushed the KM_Campaigns/sorting-algorithm-update branch 3 times, most recently from 8c963a1 to 782014e Compare January 10, 2024 00:19
dpronin added 3 commits July 4, 2024 17:23
Signed-off-by: Denis Pronin <dannftk@yandex.ru>
Signed-off-by: Denis Pronin <dannftk@yandex.ru>
Signed-off-by: Denis Pronin <dannftk@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants