fix compilation with FPC + Lazarus of campaigns sorting algorithm#198
fix compilation with FPC + Lazarus of campaigns sorting algorithm#198dpronin wants to merge 3 commits into
Conversation
ea70219 to
eb4a61d
Compare
|
I think these changes are easy to verify. We need to get list of current campaigns in the game and see that they are sorted according to the rules. Then we could create a dummy campaign, if it is possible, with the smallest efforts undertaken and name them with TSK, TPR and different other names and see that they are again sorted. Or, if it is possible and there is a list of such campaigns in resources, we might create dummy files and see that their names are sorted according to the rules |
|
Yes, this or similar test should be done. |
|
Actually, I don't have Windows, neither installed nor an installer to install |
|
as in the other MR, I could test those changes eventually |
I would appreciate if you did |
8c963a1 to
782014e
Compare
Signed-off-by: Denis Pronin <dannftk@yandex.ru>
Signed-off-by: Denis Pronin <dannftk@yandex.ru>
Signed-off-by: Denis Pronin <dannftk@yandex.ru>
782014e to
009a0cc
Compare
ff6e1b2 to
ee7819d
Compare
46e6163 to
70f2207
Compare
FPC and Lazarus on Linux do not have List.List[] property, but List fortunately has Sort() method at Linux platform with a comparator to give from a call site
Please, consider these changes to merge them in. The previous business logic of Windows's implementation has been preserved