fix(electron): preserve window bounds on reload #1417
+14
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Fixes: #999
ℹ️ About the PR
This PR resolves an issue on Windows where the application window would incorrectly maximize after a reload if it was snapped to the side of the screen.
The fix introduces a managed reload process:
menu/view.ts
no longer callsreload()
directly. Instead, it sends an IPC message (window-reload
) to the main process.main.ts
catches this message. It saves the window's current bounds (size and position), executes the reload, and then restores the saved bounds once the content has finished loading (on thedid-finish-load
event).This ensures the window's state is preserved across reloads, providing a consistent user experience.