Skip to content

ci: publish native parser libraries on version tags - #308

Merged
aspeddro merged 2 commits into
rescript-lang:mainfrom
CarlOlson:ci/release-native-binaries
Nov 4, 2026
Merged

aspeddro merged 2 commits into
rescript-lang:mainfrom
CarlOlson:ci/release-native-binaries

Conversation

@CarlOlson

Copy link
Copy Markdown
Contributor

This PR should publish the library files when a version tag is pushed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T06:54:16.214844Z 0eacd96 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@aspeddro

aspeddro commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

@CarlOlson, thanks for this PR. If we configured CI to publish a package to npm wouldn't be better? This way you can use it as a dependency in ast-grep. I'm not sure how ast-grep is configured

@CarlOlson

Copy link
Copy Markdown
Contributor Author

If we configured CI to publish a package to npm wouldn't be better?

Publishing to NPM would be good, but this alone provides value. I think doing both would be best so that scripts, tooling, and other package managers could download directly from GitHub.

This way you can use it as a dependency in ast-grep. I'm not sure how ast-grep is configured

ast-grep takes a path to a dynamic library file, so a bootstrap script could just download from GitHub:

customLanguages:
  rescript:
    libraryPath: ./result/lib/rescript.so
    extensions: [res, resi]
    expandoChar: _

There is a way to utilize grammars via JS, but it looks like it is more than just publishing library files to NPM: https://ast-grep.github.io/guide/api-usage/js-api#use-other-language

@aspeddro

aspeddro commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Ok, sounds great!! Let’s proceed this way.

@aspeddro
aspeddro merged commit cc6a15e into rescript-lang:main Nov 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants