Adds support for per-instance service account tokens #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the SDK to accept and use instance-specific service account tokens, allowing each instance to have its own authentication token separate from the customer-level token. Key changes: - Instance and AsyncInstance now accept optional service_account_token parameter - When API returns service_token on instance creation, it replaces the dynamic_token - User-provided service_account_tokens are stored and used as fallback - Both sync and async implementations updated - Examples updated to display token changes before/after instance creation - Comprehensive test coverage for token replacement behavior The implementation uses a simple token replacement pattern where the instance token replaces the customer token in state, ensuring all subsequent requests use the instance-specific token. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
crdant
changed the title
- Remove f-string without placeholders in examples - Fix line length issues by breaking long lines - Remove obsolete async tests that referenced deleted instance_token methods - Auto-format code with black - All tests passing (26/26) - All linting checks passing (flake8, mypy, black, isort) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Switches service account tokens on new instances
Details
Enables the SDK to accept and use instance-specific service
account tokens, allowing each instance to have its own authentication token
separate from the customer-level token.
Key changes:
The implementation uses a simple token replacement pattern where the
instance token replaces the customer token in state, ensuring all
subsequent requests use the instance-specific token.
Depends on replicatedhq/vandoor#8215 to function, but should still run without it.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]