Skip to content

Conversation

@enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Oct 17, 2025

Description

Updates wui-list-wallet component with the recent design changes.

  • Show the available chains as icons on the wallet item
  • Show chevron on the right
  • Remove multichain badge

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

Screenshot 2025-10-17 at 16 43 35 Screenshot 2025-10-17 at 16 43 40

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Note

Reskins wallet list item, surfaces chain namespaces as icons, wires namespaces from connectors, and removes the multichain tag while adding a right chevron.

  • UI: packages/ui
    • wui-list-wallet:
      • Add .namespaces: ChainNamespace[] prop and render chain icons (ETH/SOL/BTC) via NAMESPACE_ICONS.
      • Layout update: name + namespace icons stacked; add right chevron; keep status/tag and loading.
      • New styles for namespace icon chips and hover focus states.
    • wui-tag: prevent label wrapping with white-space: nowrap.
  • Scaffold: packages/scaffold-ui
    • w3m-list-wallet: import adapters, accept .namespaces, and forward namespaces when multi-chain adapters are present.
    • w3m-connector-list:
      • Compute connector namespaces (multi-chain aggregates, walletConnect none) and pass to list item.
      • Remove "multichain" badge; keep QR code/installed/connected tags as applicable.
  • Storybook: apps/gallery
    • Update story layout (container/background/flex) and expose namespaces arg; render with new component import.

Written by Cursor Bugbot for commit e88c0a2. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings October 17, 2025 13:45
@linear
Copy link

linear bot commented Oct 17, 2025

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: 3e7cba8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Oct 27, 2025 7:50am
appkit-demo Ready Ready Preview Comment Oct 27, 2025 7:50am
appkit-gallery Ready Ready Preview Comment Oct 27, 2025 7:50am
appkit-laboratory Ready Ready Preview Comment Oct 27, 2025 7:50am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Oct 27, 2025 7:50am
appkit-basic-sign-client-example Ignored Ignored Oct 27, 2025 7:50am
appkit-basic-up-example Ignored Ignored Oct 27, 2025 7:50am
appkit-ethers5-bera Ignored Ignored Oct 27, 2025 7:50am
appkit-nansen-demo Ignored Ignored Oct 27, 2025 7:50am
appkit-vue-solana Ignored Ignored Oct 27, 2025 7:50am
appkit-wagmi-cdn-example Ignored Ignored Oct 27, 2025 7:50am
ethereum-provider-wagmi-example Ignored Ignored Oct 27, 2025 7:50am
next-wagmi-solana-bitcoin-example Ignored Ignored Oct 27, 2025 7:50am
vue-wagmi-example Ignored Ignored Oct 27, 2025 7:50am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the wui-list-wallet component with a visual reskin that includes displaying available chains as icons, adding a chevron indicator, and removing the multichain badge. The changes align the component with updated design requirements.

  • Adds chain namespace icons to wallet items with overlapping visual styling
  • Replaces multichain badge with individual chain icons displayed on wallet items
  • Introduces chevron icon on the right side of wallet items for better UX indication

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/ui/src/layout/wui-flex/index.ts Adds CSS text styling support to flex component
packages/ui/src/composites/wui-tag/styles.ts Adds nowrap styling to prevent tag text wrapping
packages/ui/src/composites/wui-list-wallet/styles.ts Adds CSS styling for namespace icons with overlapping effect
packages/ui/src/composites/wui-list-wallet/index.ts Implements namespace icons rendering and chevron addition
packages/scaffold-ui/src/partials/w3m-list-wallet/index.ts Adds namespace handling logic for multichain scenarios
packages/scaffold-ui/src/partials/w3m-connector-list/index.ts Updates connector logic to support namespace icons instead of multichain badge
apps/gallery/stories/composites/appkit-wui-list-wallet.stories.ts Updates story configuration to showcase new namespace functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         70.18 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 319 ms   on Snapdragon 410
Total time:   1.7 s
@reown/appkit/react
Size limit:   230 kB
Size:         226.26 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 984 ms    on Snapdragon 410
Total time:   5.5 s
@reown/appkit/vue
Size limit:   80 kB
Size:         70.18 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 204 ms   on Snapdragon 410
Total time:   1.6 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         206.48 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 490 ms    on Snapdragon 410
Total time:   4.6 s
@reown/appkit-ui
Size limit:   500 kB
Size:         12.99 kB with all dependencies, minified and gzipped
Loading time: 254 ms   on slow 3G
Running time: 49 ms    on Snapdragon 410
Total time:   302 ms

@enesozturk enesozturk requested a review from a team October 17, 2025 13:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.83% 36743 / 46026
🔵 Statements 79.83% 36743 / 46026
🔵 Functions 78.13% 4023 / 5149
🔵 Branches 86.36% 8821 / 10214
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/partials/w3m-connector-list/index.ts 68.75% 85.71% 66.66% 68.75% 72, 75-77, 82-86, 90-91, 107-122, 274, 319-373, 408-449, 97-404
packages/scaffold-ui/src/partials/w3m-list-wallet/index.ts 2.97% 100% 0% 2.97% 15-155
packages/ui/src/composites/wui-list-wallet/index.ts 71.6% 40% 100% 71.6% 83-100, 107, 112-113, 117-121, 123-124, 131, 136-137
packages/ui/src/composites/wui-list-wallet/styles.ts 100% 100% 100% 100%
packages/ui/src/composites/wui-tag/styles.ts 100% 100% 100% 100%
Generated in workflow #16077 for commit 3e7cba8 by the Vitest Coverage Report Action

Copy link
Member

@magiziz magiziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svenvoskamp
Copy link
Contributor

Weird that visual regression test doesn't fail, will check that

other than that looks good!

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Visual Regression Test Results ✅ Passed

✨ No visual changes detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=240
Storybook Preview: https://6493191bf4b10fed8ca7353f-cgltljtgzd.chromatic.com/

@enesozturk enesozturk added this pull request to the merge queue Oct 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 27, 2025
@enesozturk enesozturk added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@enesozturk enesozturk added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit f739f3b Oct 30, 2025
82 of 84 checks passed
@enesozturk enesozturk deleted the enes/apkt-3969-update-wallet-selector-view-with-multi-wallet-icons-and branch October 30, 2025 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants