Skip to content

Conversation

@donaldguy
Copy link
Contributor

Before I noticed this repo existing or properly read the quick start, I noticed the existence of https://github.com/rendercv/rendercv/blob/main/uv.lock and took the queue to start using uv (as this was the first time I'd been in python land since it came onto the scene).

I had done all my local rendercv resume-writing work under a UV setup and after forking this repo for the actions pipelines, it felt like a step backward. (Broadly I am a fan of having a robust version lock)

So I did this for my own use, and thought I'd offer it upstream, take it or leave it

Warning

you should also test the devcontainer actually works properly in VSCode, I'm on macOS and while I did go down the well as microsoft/vscode-remote-release#11012 could take me, I didn't actually feel like re-installing docker for this

name = "resume"
version = "0.1.0"
description = "John Does's resume as rendered w/ RenderCV"
requires-python = ">=3.14"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, should be:

Suggested change
requires-python = ">=3.14"
requires-python = ">=3.12"

to match the change-as-little-as-possible I went for in devcontainer.json (or conversely update that to pull a 3.14 tag; I'd also go alpine probably)

I believe also determines version in rendercv pipeline?

Comment on lines -21 to -23
- name: Install RenderCV
run: |
pip install -r requirements.txt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my quick testing an explicit uv sync was not necessary — it was installed on demand at uv run time (I'm assuming differing from uvx in that it respects the lock file still),

though obviously it might be better for cache coherence?

(but if that level of optimization is a goal I'd suggest that y'all might just want to push a full fledged container into ghcr.io/rendercv/rendercv [ see also porting this whole repo to being a GitHub action] )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant