Remove need for #/ with HashRouter basename="" - #8460
Closed
thejohnhoffer wants to merge 2 commits into
Closed
Conversation
This was referenced Dec 9, 2021
Contributor
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
1 similar comment
Contributor
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
thejohnhoffer
changed the title
Contributor
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Contributor
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Member
|
Thanks but we'll keep the |
Author
|
This is now possible with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #8459.
I've created a codepen to show the results of this PR against the latest release.
I've created a hook called
useNavigator, which wraps the router's navigator object. This wrapping only occurs whenbasename="". This wrapped navigator serializes eachpathnamewithout the leading/. The difference can only be seen when<HashRouter basename="">.The difference is that paths are written to the URL like
#abcinstead of#/abc.