Skip to content

feat(studio): hide-AI setting, macOS window controls, onboarding tour, Drizzle operator intellisense - #222

Merged
remcostoeten merged 1 commit into
masterfrom
feat/settings-tour-lsp
Jul 26, 2026
Merged

feat(studio): hide-AI setting, macOS window controls, onboarding tour, Drizzle operator intellisense#222
remcostoeten merged 1 commit into
masterfrom
feat/settings-tour-lsp

Conversation

@remcostoeten

@remcostoeten remcostoeten commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Grouped feature PR (per request — fewer PRs), four independent features:

#163 — Hide AI entirely

New Settings → Safety → Hide AI toggle (default off, existing users unaffected). When on:

  • corner AI button + assistant panel unmount, and the toggle-assistant shortcut no-ops
  • SQL console: Cmd+K generation disabled, 'Explain with AI' button hidden, 'Fix with AI' on errors hidden
  • all four AI settings sections (Provider, Local models, Keys, Usage) disappear from the settings panel and its nav

#165 — Window controls style (partial)

New Settings → Interface → Window Controls select: custom (current) or macos traffic lights (close/min/max dots with hover glyphs, Tauri only), persisted. Position (left/right) is deferred — WindowControls is mounted in ~7 header rightSlots and moving it left needs per-header layout work (the #164 concern the issue itself references). Leaving #165 open for that half, with a comment.

#160 — Skippable onboarding tour

Non-intrusive 5-step coachmark (bottom-center card + spotlight ring on the nav rail; no dimming overlay, app stays usable). Driven by a persisted launch counter (per the issue's note) in localStorage — which persists in the Tauri webview too: offers on the first 3 launches until completed or skipped, never again after. Nav anchors via a new data-nav-id on nav items.

#176 — Drizzle operator intellisense

Beyond the existing completions, the runner now has:

  • Signature help inside operator calls (eq(, between(, …) with correct active-parameter tracking — a forward call-stack parser handles nested calls, arrays, objects, and unterminated strings (findEnclosingOperatorCall, 12 unit tests)
  • Hover docs for eq/ne/gt/gte/lt/lte/like/ilike/inArray/notInArray/between/and/or/not/isNull/isNotNull
  • Both providers disposed alongside the completion provider.

Verification

  • 813 tests pass (18 new: 12 operator-signatures, 6 launch-state)
  • studio + desktop typecheck, lint clean

Closes #163
Closes #160
Closes #176

Summary by Sourcery

Add user-configurable controls for AI visibility, window button style, onboarding guidance, and Drizzle operator tooling in Studio.

New Features:

  • Introduce a Hide AI safety setting that removes all AI entry points and assistant UI when enabled.
  • Add an Interface setting to switch desktop window controls between custom buttons and macOS-style traffic lights.
  • Add a skippable, multi-step onboarding tour that spotlights key navigation items and is gated by a persisted launch counter.
  • Provide signature help and hover documentation for common Drizzle condition operators in the runner code editor.

Enhancements:

  • Dispose Drizzle runner hover and signature providers alongside the completion provider to avoid leaks.

Tests:

  • Add unit tests for Drizzle operator signature metadata and the enclosing-operator parser used for signature help.
  • Add unit tests for onboarding launch state behavior, including corrupted counters and completion gating.

@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dora Ready Ready Preview, Comment Jul 26, 2026 5:07pm

@sourcery-ai

sourcery-ai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@remcostoeten, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 95224eed-1ae3-42a9-a0a7-26395f2758ba

📥 Commits

Reviewing files that changed from the base of the PR and between ff36fe9 and 3828768.

📒 Files selected for processing (14)
  • __tests__/apps/desktop/src/features/drizzle-runner/utils/operator-signatures.test.ts
  • __tests__/apps/desktop/src/features/onboarding/launch-state.test.ts
  • packages/studio/src/components/window-controls.tsx
  • packages/studio/src/core/settings/settings-store.tsx
  • packages/studio/src/features/app-sidebar/nav-item.tsx
  • packages/studio/src/features/drizzle-runner/components/code-editor.tsx
  • packages/studio/src/features/drizzle-runner/utils/operator-signatures.ts
  • packages/studio/src/features/onboarding/index.ts
  • packages/studio/src/features/onboarding/launch-state.ts
  • packages/studio/src/features/onboarding/onboarding-tour.tsx
  • packages/studio/src/features/sidebar/components/settings-panel.tsx
  • packages/studio/src/features/sql-console/components/sql-results.tsx
  • packages/studio/src/features/sql-console/sql-console.tsx
  • packages/studio/src/pages/Index.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/settings-tour-lsp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…, Drizzle operator intellisense

Four grouped features:
- Settings > Safety gains 'Hide AI' — removes the assistant panel + corner button, Cmd+K generation, AI explain/fix actions, the AI shortcut, and all four AI settings sections (#163).
- Settings > Interface gains a window-controls style switch: custom buttons or macOS traffic lights, persisted (#165 — position left/right deferred, needs per-header layout work).
- Skippable 5-step onboarding tour on first launch: coachmark card + spotlight on the nav rail, driven by a persisted launch counter (offers for the first 3 launches until completed/skipped) (#160).
- Drizzle runner gains real intellisense for condition operators: Monaco signature help (active-parameter tracking via a forward call-stack parser) and hover docs for eq/ne/gt/gte/lt/lte/like/ilike/inArray/notInArray/between/and/or/not/isNull/isNotNull (#176).

Closes #163
Closes #160
Closes #176
@remcostoeten
remcostoeten merged commit 522b897 into master Jul 26, 2026
10 checks passed
@remcostoeten
remcostoeten deleted the feat/settings-tour-lsp branch July 26, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drizzle Runner: proper eq LSP support Add a setting to hide AI entirely from the app Add a skippable onboarding tour on initial launch

1 participant