Skip to content

[0.9] remove ids refs from form_data #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[0.9] remove ids refs from form_data #5430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09920d4
remove ids refs from form_data
Lendemor Jun 10, 2025
32ff737
fix tests
Lendemor Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyi_hashes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"reflex/components/el/element.pyi": "3519fdc9a74aab7b02f475568def5f95",
"reflex/components/el/elements/__init__.pyi": "baeddd04d4d3a82799420b2a6df368f6",
"reflex/components/el/elements/base.pyi": "2c962706dd6c28821497e9c8044cab4e",
"reflex/components/el/elements/forms.pyi": "0a75b05da0e53f581e356e464d3675d2",
"reflex/components/el/elements/forms.pyi": "7d96e23d763f4dcfc179a40fc205d895",
"reflex/components/el/elements/inline.pyi": "523f3d432fb0daa21a4036bb37b4c8fa",
"reflex/components/el/elements/media.pyi": "7d2f7996b2bbac9dff223e44e8c9b02d",
"reflex/components/el/elements/metadata.pyi": "1591385cc150bf113b689bf4b58e67f2",
Expand Down
3 changes: 1 addition & 2 deletions reflex/components/el/elements/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
const handleSubmit_{{ handle_submit_unique_name }} = useCallback((ev) => {
const $form = ev.target
ev.preventDefault()
const {{ form_data }} = {...Object.fromEntries(new FormData($form).entries()), ...{{ field_ref_mapping }}};
const {{ form_data }} = {...Object.fromEntries(new FormData($form).entries())};

({{ on_submit_event_chain }}(ev));

Expand Down Expand Up @@ -217,7 +217,6 @@ def add_hooks(self) -> list[str]:
HANDLE_SUBMIT_JS_JINJA2.render(
handle_submit_unique_name=self.handle_submit_unique_name,
form_data=FORM_DATA,
field_ref_mapping=str(LiteralVar.create(self._get_form_refs())),
on_submit_event_chain=str(
LiteralVar.create(self.event_triggers[EventTriggers.ON_SUBMIT])
),
Expand Down
4 changes: 0 additions & 4 deletions tests/integration/test_form_submit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,11 @@ def index():
@pytest.fixture(
scope="module",
params=[
functools.partial(FormSubmit, form_component="rx.form.root"),
functools.partial(FormSubmitName, form_component="rx.form.root"),
functools.partial(FormSubmit, form_component="rx.el.form"),
functools.partial(FormSubmitName, form_component="rx.el.form"),
],
ids=[
"id-radix",
"name-radix",
"id-html",
"name-html",
],
)
Expand Down