fix(hybrid-query): use ADDSCORES to enable proper BM25 text scoring #16
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, HybridQuery hardcoded text_score to 1.0, making the hybrid formula effectively ignore text relevance. This was an incomplete port from the Python RedisVL implementation. Changes: - Add aggregation.addScores() to enable the @__score field in FT.AGGREGATE - Use @__score (the actual BM25/text search score) instead of hardcoded 1.0 - Update Javadoc to document Redis 7.4.0+ requirement for ADDSCORES - Update formula documentation to clarify the scoring mechanism The hybrid scoring formula now correctly applies: hybrid_score = (1 - alpha) * text_score + alpha * vector_similarity Where text_score is the actual BM25 score from Redis, not a constant. Requires: Redis 7.4.0+ Reference: Python redisvl/query/aggregate.py lines 168-173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, HybridQuery hardcoded text_score to 1.0, making the hybrid formula effectively ignore text relevance. This was an incomplete port from the Python RedisVL implementation.
Changes:
The hybrid scoring formula now correctly applies:
hybrid_score = (1 - alpha) * text_score + alpha * vector_similarity
Where text_score is the actual BM25 score from Redis, not a constant.
Requires: Redis 7.4.0+
Reference: Python redisvl/query/aggregate.py lines 168-173