Fix SharedLock ThreadLocal threadWriters memory leak may cause CPU usage to reach 100% #3554
+47
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR SharedLock.decrementWriters() to call threadWriters.remove() when the per-thread writer depth reaches zero, preventing unused ThreadLocal entries from lingering.
This helps avoid the ThreadLocalMap.expungeStaleEntry() CPU spikes reported in #3489
Thanks !
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.