fix consistency with get(int) that returns wrapped DelegateJsonObject/DelegateJsonArray for nested structures #3464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelegateJsonObject/DelegateJsonArray for nested structures Signed-off-by: NeatGuyCoding <[email protected]>
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Collaborator
|
Thank you for the contribution! |
ggivo
added a commit
that referenced
this pull request
Dec 11, 2025
…lover-1 (#3575) * add Benchmark (jmh) benchmark result for 1343845 * Bump to 8.4-GA-pre.3 (#3516) * add Benchmark (jmh) benchmark result for e8d59fc * Add official 8.4 to test matrix and make it default (#3520) * Add support for XREADGROUP CLAIM arg (#3486) * Add support for XREADGROUP CLAIM arg * Add NOACK scenario in ITs * Fix NOACK IT scenario. Add test. * Implement new fields as integers. Fix tests. * Rename values for consistency. * Address some comments from code review * add Benchmark (jmh) benchmark result for 295546c * Add support CAS/CAD (#3512) * Implement CAS/CAD commands * Add tests * Fix readonly commands count * Remove not needed license comments. * Implement msetex command (#3510) * Implement msetex command * Refactor to use SetArgs * Use dedicated MSetExArgs for MSETEX command * Fix formatting * Keep only instant/duration API * Rm not needed license comment. * Fix tests * Preserve null values when parsing SearchReplies (#3518) EncodedComplexOutput was skipping null values instead of passing them on. Then SearchReplyParser needs to store null values as they are and not try to decode them. This affected both RESP2 and RESP3 parsing. Added two integration tests in RediSearchAggregateIntegrationTests to verify that nulls in JSON documents are parsed correctly. * add Benchmark (jmh) benchmark result for 0796a4e * Modify release notes and bum pom version. (#3525) * add Benchmark (jmh) benchmark result for 7fefd6a * add Benchmark (jmh) benchmark result for 838fe47 * add Benchmark (jmh) benchmark result for 73a7bab * add Benchmark (jmh) benchmark result for 0e49f73 * SearchArgs.returnField with alias produces malformed redis command #3528 (#3530) * add Benchmark (jmh) benchmark result for a4eab37 * fix consistency with get(int) that returns wrapped (#3464) DelegateJsonObject/DelegateJsonArray for nested structures Signed-off-by: NeatGuyCoding <[email protected]> * Bumping Netty to 4.2.5.Final (#3536) * add Benchmark (jmh) benchmark result for 274af38 * add Benchmark (jmh) benchmark result for 8f2080a * add Benchmark (jmh) benchmark result for fe79196 * add Benchmark (jmh) benchmark result for 289398b * add Benchmark (jmh) benchmark result for 2f226a6 * add Benchmark (jmh) benchmark result for a1bb28d * add Benchmark (jmh) benchmark result for d7e6a0a * add Benchmark (jmh) benchmark result for 9230a17 * Add ftHybrid (#3540) * Add ftHybrid * rm max, withCount from SortBy * refactor CombineArgs * Move postprocessing inside PostProcessingArgs * Refactor VectorSearchMethod * Mark new files as experimental * Format * Fix RESP2 parsing * Fix tests for previous versions * Minor fixes in tests * Format * Add enabled on command * Refactor scoring * Tighten integration test with field assertions * Rm commented loadALl * Use keywords instead magic strings * Fixed Range building * Rm defaults from javadoc * Expose method to add upstream driver libraries to CLIENT SETINFO payload (#3542) * Expose method to add upstream driver libraries to CLIENT SETINFO payload * Create a separate class to hold driver name and upstream drivers information * Fix PR comments * Update since tag * add Benchmark (jmh) benchmark result for be132f9 * Release 7.2.0 (#3559) * add Benchmark (jmh) benchmark result for fdcfb74 * Fix command queue corruption on encoding failures (#3443) * Correctly handling the encoding error for Lettuce [POC] Summary: Add encoding error tracking to prevent command queue corruption - Add markEncodingError() and hasEncodingError() methods to RedisCommand interface - Implement encoding error flag in Command class with volatile boolean - Mark commands with encoding errors in CommandEncoder on encode failures - Add lazy cleanup of encoding failures in CommandHandler response processing - Update all RedisCommand implementations to support encoding error tracking - Add comprehensive unit tests and integration tests for encoding error handling Fixes issue where encoding failures could corrupt the outstanding command queue by leaving failed commands in the stack without proper cleanup, causing responses to be matched to wrong commands. Test Plan: UTs, Integration testing Reviewers: yayang, ureview Reviewed By: yayang Tags: #has_java JIRA Issues: REDIS-14050 Differential Revision: https://code.uberinternal.com/D19068147 * Fix error command handling code logic and add integration test for encoding failure Summary: Fix error command handling code logic and add integration test for encoding failure Test Plan: unittest, integration test Reviewers: #ldap_storage_sre_cache, ureview, jingzhao Reviewed By: #ldap_storage_sre_cache, jingzhao Tags: #has_java JIRA Issues: REDIS-14192 Differential Revision: https://code.uberinternal.com/D19271701 * latest changes * Addressing the reactive streams issue * Addressing the encoding issues Addressing some general cases * Formatting issues * Test failures addressed * Polishing --------- Co-authored-by: Jing Zhao <[email protected]> Co-authored-by: Tihomir Mateev <[email protected]> * add Benchmark (jmh) benchmark result for f65b8d1 * add Benchmark (jmh) benchmark result for c6b42f0 * add Benchmark (jmh) benchmark result for 5c5f117 * add Benchmark (jmh) benchmark result for 329c39c * add Benchmark (jmh) benchmark result for fa7e5d0 --------- Signed-off-by: NeatGuyCoding <[email protected]> Co-authored-by: github-action-benchmark <[email protected]> Co-authored-by: Aleksandar Todorov <[email protected]> Co-authored-by: Magnus Hyllander <[email protected]> Co-authored-by: Tihomir Krasimirov Mateev <[email protected]> Co-authored-by: NeatGuyCoding <[email protected]> Co-authored-by: Viktoriya Kutsarova <[email protected]> Co-authored-by: yang <[email protected]> Co-authored-by: Jing Zhao <[email protected]> Co-authored-by: Tihomir Mateev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.In src/main/java/io/lettuce/core/json/DelegateJsonArray.java around lines 61-63, asList() currently constructs elements using new DelegateJsonValue(jsonNode,objectMapper) which breaks consistency with get(int) that returns wrapped DelegateJsonObject/DelegateJsonArray for nested structures
Add unit tests for those scenarios