DEV: add TCEs to HEXPIRE command page #2253
Conversation
| }).thenAccept(res4 -> { | ||
| System.out.println(res4); | ||
| // >>> [-2] | ||
| // REMOVE_START | ||
| assertThat(res4).isEqualTo(Arrays.asList(-2L)); | ||
| // REMOVE_END | ||
| }).toCompletableFuture(); |
There was a problem hiding this comment.
This works fine, but the visible code reduces to thenAccept(res4 -> { System.out.println(res4);}).... This kind of lambda would normally be shortened even further into a method reference in Java 8+ style, so in the other examples, we often have a hidden thenApply(...) for the assertions, and then use the method reference .thenAccept(System.out::println) to print the output (see the suggestion for an example). It's fine if you leave the code as it is, but I was thinking maybe you could easily add a note for Augie to follow the way we use method refs in the other examples.
| }).thenAccept(res4 -> { | |
| System.out.println(res4); | |
| // >>> [-2] | |
| // REMOVE_START | |
| assertThat(res4).isEqualTo(Arrays.asList(-2L)); | |
| // REMOVE_END | |
| }).toCompletableFuture(); | |
| }) | |
| // REMOVE_START | |
| .thenApply(res4 -> { | |
| assertThat(res4).isEqualTo(Arrays.asList(-2L)); | |
| return res; | |
| }) | |
| // REMOVE_END | |
| .thenAccept(System.out::println) | |
| // >>> -2 | |
| .toCompletableFuture(); |
| // >>> Hello, World | ||
| // STEP_END | ||
| Assert.Equal("Hello, World", string.Join(", ", hValsResult)); | ||
| db.KeyDelete("myhash"); |
There was a problem hiding this comment.
The key deletion is in a REMOVE section in the other examples, and the assertion above probably should be visible to users either.
| ); | ||
|
|
||
| // Set expiration on hash fields using raw Execute | ||
| RedisResult hexpireRes1 = db.Execute("HEXPIRE", "myhash", 10, "FIELDS", 2, "field1", "field2"); |
There was a problem hiding this comment.
This is actually implemented in the library now (HashFieldExpire(), etc) so the catchall Execute isn't necessary. I've found you sometimes need to nudge Augie in the right direction for C# because the API method names typically don't closely resemble the command names (other clients occasionally have trip-ups like this too).
| echo "\n--- HEXPIRE Command ---\n"; | ||
| // Clean up first | ||
| $this->redis->del('myhash'); |
There was a problem hiding this comment.
We don't usually have these extra explanatory lines in the example output (bit of Augie randomness, I guess :-) ). Also, we'd normally have the del() command and the assertions in REMOVE sections.
2 participants
No description provided.