Skip to content

DOC-5665 updated failover docs with new API #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

DOC-5665 updated failover docs with new API #2229

wants to merge 15 commits into from
+151 −153

Conversation

andy-stark-redis
Copy link
Contributor

There was already a page of docs for this (hidden temporarily as a draft), but this PR updates the doc with the finalised API.

@andy-stark-redis andy-stark-redis requested a review from a team October 13, 2025 14:36
@andy-stark-redis andy-stark-redis self-assigned this Oct 13, 2025
@andy-stark-redis andy-stark-redis added the clients Client library docs label Oct 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025 •
edited by atlassian bot
Loading

DOC-5665

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025 •
edited
Loading

Staging links:
https://redis.io/docs/staging/DOC-5665-failover-updates/develop/clients/jedis/
https://redis.io/docs/staging/DOC-5665-failover-updates/develop/clients/jedis/failover/

atakavci
atakavci reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@atakavci atakavci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes i suggested.

I wonder if we don't use default values in code samples on purpose.
If we have reasoning, then its all fine to me.

atakavci
atakavci reviewed Oct 14, 2025
View reviewed changes
@andy-stark-redis
Copy link
Contributor Author

@atakavci Great feedback, thanks! I've applied all your suggestions.

dwdougherty
dwdougherty approved these changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments: one I'm certain needs to be fixed; the other ? I'll go ahead and approve.

ggivo
ggivo reviewed Oct 16, 2025
View reviewed changes
@andy-stark-redis
Copy link
Contributor Author

@ggivo Thanks for the improvements!

ggivo
ggivo reviewed Oct 16, 2025
View reviewed changes
Copy link

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@uglide uglide Awaiting requested review from uglide

+2 more reviewers

@atakavci atakavci atakavci left review comments

@ggivo ggivo ggivo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@andy-stark-redis andy-stark-redis

Labels

clients Client library docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andy-stark-redis @dwdougherty @atakavci @ggivo