-
Notifications
You must be signed in to change notification settings - Fork 426
RI-7839: standardize loader behavior in pipeline and analytics pages #5319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
References: #RI-7839
…e loader backdrop References: #RI-7839
6d4014a
| <DataStreams data={statisticsData.dataStreams} /> | ||
| <Clients data={statisticsData.clients} /> | ||
| </> | ||
| !pageLoading && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Empty component renders alongside loader during initial load
The Empty component renders during initial page load alongside the loader because it's not gated by pageLoading. When statisticsResults is null (initial state), shouldShowStatistics returns false, so Empty renders even while pageLoading is true. The statistics content was correctly gated with !pageLoading &&, but the Empty branch wasn't given the same treatment. This creates inconsistent behavior where users see both the loader and empty state simultaneously during initial load.
Additional Locations (1)
References: #RI-7839
Code Coverage - Frontend unit tests
Test suite run success5481 tests passing in 703 suites. Report generated by 🧪jest coverage report action from 27086e4 |
What
Fix inconsistent loader behavior in RDI pipeline and analytics pages per designer feedback
Before:
Screen.Recording.2025-11-21.at.17.16.01.mov
After:
Screen.Recording.2025-12-08.at.12.13.40.mov
Changes:
styles.module.scssCloses #RI-7839
Testing
Pipeline page - Deploy action:
Analytics/Statistics page:
Note
Standardizes loaders by removing deploy button spinner, limiting Test Connection spinner to test action, using skeletons in navigation, and refactoring Statistics page to styled-components with a centered non-overlay loader; tests updated accordingly.
DeployPipelineButton: makeloadingprop optional; remove usage inPipelineActionsso deploy button stays disabled without a spinner.Config.tsx:Test Connectionbutton showsloadingonly during testing (testingConnections) and is disabled during pipeline loading; editor shows loader while pipeline loading.Navigation.tsx: replace spinner with skeleton loader viaLoadingContent.StatisticsPage.styles.ts), removestyles.module.scss.pageLoadingis false.Config.spec.tsxandStatisticsPage.spec.tsx.Written by Cursor Bugbot for commit 27086e4. This will update automatically on new commits. Configure here.