RI-7593, RI-7594, RI-7595, RI-7528 wb issues #5039
Merged
+245
−390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd-redis
requested review from
ArtemHoruzhenko,
KrumTy,
dantovska,
pawelangelow and
valkirilov
as code owners
fix deprecated calls in WorkbenchPage.spec.tsx changed the test for `check button clickable and selected` to test if the actual action is executed because rerendering seems to not play well with styled components
Contributor
Code Coverage - Frontend unit tests
Test suite run success5162 tests passing in 677 suites. Report generated by 🧪jest coverage report action from 0b12e22 |
valkirilov
previously approved these changes
Oct 8, 2025
* RI-7609: replace custom action buttons with ToggleButton RI-7607: replace purple border with colors we use in keys list onnhover * RI-7607: remove QABtn
ArtemHoruzhenko
dismissed stale reviews from valkirilov and themself
via
076711f
ArtemHoruzhenko
previously approved these changes
Oct 8, 2025
pd-redis
changed the title
valkirilov
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RI-7595: Raw/Group buttons
Before:
After:
RI-7593: Processing time misalignment
Before:
After:
RI-7594: Profile/Explain display mode selector icon
Before:
After:
RI-7594: Query header icons
Before:
After:
Profile/Explain dropdown icon still looks different because of the dynamic nature of loading it.
In my opinion this should be refactored in general, but it is a bit out of scope for this ticket
RI-7594: Profile command works
Before:
After: