Skip to content

updating to operator-sdk 1.39 and kubebuilder v4 scaffolding#165

Merged
bcrochet merged 1 commit intoredhat-openshift-ecosystem:mainfrom
acornett21:remove_kube_rbac
Feb 5, 2025
Merged

updating to operator-sdk 1.39 and kubebuilder v4 scaffolding#165
bcrochet merged 1 commit intoredhat-openshift-ecosystem:mainfrom
acornett21:remove_kube_rbac

Conversation

@acornett21
Copy link
Copy Markdown
Contributor

  • Updating to operator-sdk 1.39

Sample CSV deployment section

      deployments:
      - label:
          control-plane: controller-manager
        name: certification-operator-controller-manager
        spec:
          replicas: 1
          selector:
            matchLabels:
              control-plane: controller-manager
          strategy: {}
          template:
            metadata:
              annotations:
                kubectl.kubernetes.io/default-container: manager
              labels:
                control-plane: controller-manager
            spec:
              containers:
              - args:
                - --metrics-bind-address=:8443
                - --leader-elect
                - --health-probe-bind-address=:8081
                command:
                - /manager
                env:
                - name: GIT_REPO_PATH
                  value: /git
                image: quay.io/acornett/operator-certification-operator:latest
                imagePullPolicy: Always
                livenessProbe:
                  httpGet:
                    path: /healthz
                    port: 8081
                  initialDelaySeconds: 15
                  periodSeconds: 20
                name: manager
                readinessProbe:
                  httpGet:
                    path: /readyz
                    port: 8081
                  initialDelaySeconds: 5
                  periodSeconds: 10
                resources:
                  limits:
                    cpu: 200m
                    memory: 100Mi
                  requests:
                    cpu: 100m
                    memory: 20Mi
                securityContext:
                  allowPrivilegeEscalation: false
                volumeMounts:
                - mountPath: /git
                  name: pipeline-clone-volume
              securityContext:
                runAsNonRoot: true
              serviceAccountName: certification-operator-controller-manager
              terminationGracePeriodSeconds: 10
              volumes:
              - emptyDir: {}
                name: pipeline-clone-volume

@acornett21 acornett21 requested a review from bcrochet February 5, 2025 18:07
@openshift-ci openshift-ci bot requested review from mrhillsman and skattoju February 5, 2025 18:07
Copy link
Copy Markdown
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions about TODOs and image path.

Signed-off-by: Adam D. Cornett <adc@redhat.com>
Copy link
Copy Markdown
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@bcrochet bcrochet merged commit 37174a1 into redhat-openshift-ecosystem:main Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants