Skip to content

Export Telemetry type#917

Open
remcohaszing wants to merge 1 commit intoredhat-developer:mainfrom
remcohaszing:export-telemetry
Open

Export Telemetry type#917
remcohaszing wants to merge 1 commit intoredhat-developer:mainfrom
remcohaszing:export-telemetry

Conversation

@remcohaszing
Copy link
Contributor

What does this PR do?

Export the Telemetry type.

Alternatively it could be defined in yamlLanguageService.ts.

What issues does this PR fix or reference?

This is used by monaco-yaml.

Is it tested? How?

No.

@gorkem
Copy link
Collaborator

gorkem commented Oct 7, 2023

Can we alternately add telemetry.ts to index.ts ? This would also export TelemetryEvent which I feel maybe needed if a client really wants to send events.

@remcohaszing
Copy link
Contributor Author

I think you meant to move it into yamlLanguageService, of which everything is also re-exported in index.ts. Otherwise language service code would have to import language server code.

@coveralls
Copy link

Coverage Status

coverage: 84.071%. remained the same
when pulling 4212cc9 on remcohaszing:export-telemetry
into d354c58 on redhat-developer:main.

@coveralls
Copy link

coveralls commented Dec 18, 2024

Coverage Status

coverage: 84.189%. remained the same
when pulling e147903 on remcohaszing:export-telemetry
into c1cab4d on redhat-developer:main.

This is used by `monaco-yaml`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants