Skip to content

DFBUGS-9065:[release-4.20] fix: clear absent provider fields on reconcile - #697

Open
leelavg wants to merge 1 commit into
red-hat-storage:release-4.20from
leelavg:fields-420
Open

DFBUGS-9065:[release-4.20] fix: clear absent provider fields on reconcile#697
leelavg wants to merge 1 commit into
red-hat-storage:release-4.20from
leelavg:fields-420

Conversation

@leelavg

@leelavg leelavg commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Zero object before unmarshal so disabled fields (e.g. readAffinity) are cleared on the live object rather than silently retained via json merge accumulation. Preserve labels, annotations, ownerRefs, resourceVersion and creationTimestamp across the reset.

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
controllers: clear absent provider fields on reconcile
487c6b1 
Zero object before unmarshal so disabled fields (e.g. readAffinity)
are cleared on the live object rather than silently retained via
json merge accumulation. Preserve labels, annotations, ownerRefs,
resourceVersion and creationTimestamp across the reset.

Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
@leelavg leelavg changed the title [release-4.20] fix: clear absent provider fields on reconcile DFBUGS-9065:[release-4.20] fix: clear absent provider fields on reconcile Jul 29, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jul 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@leelavg: This pull request references [Jira Issue DFBUGS-9065](https://redhat.atlassian.net/browse/DFBUGS-9065), which is invalid:

  • expected the bug to target the "odf-4.20.16" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Zero object before unmarshal so disabled fields (e.g. readAffinity) are cleared on the live object rather than silently retained via json merge accumulation. Preserve labels, annotations, ownerRefs, resourceVersion and creationTimestamp across the reset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leelavg

leelavg commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved do-not-merge/hold jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leelavg @openshift-ci-robot