bundle: remove operator-config from bundle for olm v1 - #645
Open
leelavg wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold |
in v0 we were using this configmap for tweaking operator knobs but v1 doesn't allow resources deployed by bundle to be reconciled by us and the plan is to remove the config from the bundle eventually, this commit is to try out the flow early. next step would be removing csv as owner of configmap and then remove the configmap from the bundle itself during v1 migration. Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in v0 we were using this configmap for tweaking operator knobs but v1 doesn't allow resources deployed by bundle to be reconciled by us and the plan is to remove the config from the bundle eventually, this commit is to try out the flow early.
next step would be removing csv as owner of configmap and then remove the configmap from the bundle itself during v1 migration.