Redo OPDS feed to use SwiftUI #671
Open
+683
−1,301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
24
to
27
| id = publication.links.first(where: { $0.rels.contains(.self) })?.href | ||
| ?? publication.metadata.identifier | ||
| ?? publication.metadata.title | ||
| ?? UUID().uuidString |
Member
There was a problem hiding this comment.
This is somewhat fragile because you could have multiple publications with the same identifier (unlikely) or title (likely). This means we must later use the .unique() trick, which should not be necessary.
Instead, I would use the index of the publication in the feed list for ID, as it should not change during the rendition of the feed. Maybe prefixed with the feed URL (and the index of a group if needed?, so that it would look like 1.4).
What do you think?
Contributor
Author
There was a problem hiding this comment.
Let me know how the fix looks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redoes the OPDS feed screens to use SwiftUI and removes their old UIKit counterparts.